Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(images): images suited for black background #126

Closed
wants to merge 1 commit into from

Conversation

shrutimantri
Copy link
Contributor

No description provided.

Copy link
Member

@wrussell1999 wrussell1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the icon to handle black / white theme, example of wrong one, good one. The main difference is :
fill="currentColor"
that allow to change the color of the svg.
Please take care of this?

@anna-geller
Copy link
Member

@shrutimantri @wrussell1999 what's the status of this one?

cc @Ben8t

@wrussell1999
Copy link
Member

This one is going to need rethinking. The issue isn't the icon imgs, but more we need to change the color of the SVG depending on the mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants