Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/http-trigger-with-encrypted-body #110

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

brian-mulier-p
Copy link
Member

closes #104

@brian-mulier-p brian-mulier-p self-assigned this Mar 19, 2024
@brian-mulier-p
Copy link
Member Author

@loicmathieu & @anna-geller I'm unsure it's the way we want to handle this issue. Basically the old version isn't working as we have an encryptedBody the whole way long (meaning that even in responseCondition we should use encryptedBody) but we don't decrypt it before evaluating the responseCondition.

We can keep that behaviour but add a decrypt step (however it would imply that we move the decrypt method visibility to public in RunContext @loicmathieu) or do as I did here where we execute the request without asking to encrypt body, then we encrypt it before creating the execution from trigger.

The only con I see with that is the discrepancy for reaching out the body as responseCondition is positioned before the encryption (so we reach it out with .body) while in tasks we get a .encryptedBody from trigger variable

@brian-mulier-p
Copy link
Member Author

@anna-geller FYI after discussion with Loïc, we came to the point that it wasn't a security issue to put decrypt method as public in the runContext which allow the trigger task to keep calling Request task with encrypted body and decrypt it on the fly before evaluating the responseCondition

…ld not be taken care of in responseCondition

closes #104
@brian-mulier-p brian-mulier-p force-pushed the fix/http-trigger-with-encrypted-body branch from 2562612 to 615c7d4 Compare March 20, 2024 09:01
@brian-mulier-p brian-mulier-p merged commit 8d76b1e into master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Trigger with Encrypted Body doesn't trigger executions
1 participant