-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Refactor / Improvements / Add Documentation #13
Merged
anna-geller
merged 11 commits into
kestra-io:main
from
japerry911:python/japerry911-refactor
Feb 1, 2025
Merged
Python Refactor / Improvements / Add Documentation #13
anna-geller
merged 11 commits into
kestra-io:main
from
japerry911:python/japerry911-refactor
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-geller
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, Jack 🙏
Thank you for review @anna-geller , I am working on some updates - hold off on merging please 🙏 |
…ytest_mock dependency to test extras & ignore long lines for flake8 for tests/* files
Changes InfoNew
Improvements
Notes to be read prior to merge
Thank you team for allowing me to contribute 😸 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
Hello, I needed to update some of the Kestra Python library for our internal Streamlit app; I thought it would be worthwhile to open a PR for the Fork, in case there is interest in how it is updated.
Updates:
I am sorry that this PR is not super thorough, that the unit tests are not expansive, and that the commits are not conventional standard (I literally just saw that requirement when I opened PR description 😿 🤦 .
I ended up doing it on the side so that we could have the API Token/Tenant functionality on our end. I am happy/definitely would be grateful to help upgrade and add/improve the Kestra Python Library more starting in the near future after this streamlit POC I am working on passes.
Would that be helpful?
Notes/Thoughts
How the changes have been QAed?
(Skylord is a 🐶)
Setup Instructions
Let me know any and all updates needed, happy to help!