Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Clicking on label will update this in filter from url. #7232

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Piyush-r-bhaskar
Copy link
Contributor

Closes #5997

labels.mp4

@MilosPaunovic MilosPaunovic self-requested a review February 7, 2025 07:41
@MilosPaunovic
Copy link
Member

Hey @Piyush-r-bhaskar, could you resolve the merge conflict before I take a look at this? And bare in mind we've merged a PR yesterday evening which changes a bit how filters work, can you make sure this is properly functioning in the new way?

@Piyush-r-bhaskar
Copy link
Contributor Author

Sure @MilosPaunovic I will check...
Also could you share the PR of yesterday.

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Feb 7, 2025

That would be this one 5a8a4e9.

@Piyush-r-bhaskar
Copy link
Contributor Author

Done @MilosPaunovic

Also, there was a console log from Labels.vue which was causing rendering issue of labels on refresh- Fixed

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are for solving array map error from the console.

@tchiotludo tchiotludo force-pushed the develop branch 2 times, most recently from d2d8668 to 0c3ed3b Compare February 7, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On hold
Development

Successfully merging this pull request may close these issues.

Clicking on label does not update filter
2 participants