fix(): correct usage of paths-filter action

kestra-io · Feb 7, 2025 · 4c32bfe · 4c32bfe
1 parent 690397e
commit 4c32bfe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/actions/action-frontend-test/action.yml b/.github/actions/action-frontend-test/action.yml
@@ -4,6 +4,9 @@ inputs:
   github-token:
     description: 'GitHub Token'
     required: true
+  codecov-token:
+    description: 'Codecov Token'
+    required: true
 
 
 runs:
@@ -12,7 +15,7 @@ runs:
     - id: checkout
       uses: actions/checkout@v4
       with:
-        ref: ${{ github.ref_name }} # Using ref_name in case translations has committed something
+        ref: ${{ github.ref }} # Using ref in case translations has committed something
 
     - name: Npm install
       shell: bash
@@ -22,15 +25,15 @@ runs:
     - name: Npm lint
       uses: reviewdog/action-eslint@v1
       with:
-        github_token: ${{ inputs.GITHUB_TOKEN }}
+        github_token: ${{ inputs.github-token }}
         reporter: github-pr-review # Change reporter.
         workdir: "ui"
 
     - name: Npm - Run build
       shell: bash
       working-directory: ui
       env:
-        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        CODECOV_TOKEN: ${{ inputs.codecov-token }}
       run: npm run build
 
     - name: Run front-end unit tests

diff --git a/.github/workflows/workflow-pr.yml b/.github/workflows/workflow-pr.yml
@@ -61,6 +61,7 @@ jobs:
         uses: ./.github/actions/action-frontend-test
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
+          codecov-token: ${{ secrets.CODECOV_TOKEN }}
 
   backend:
     name: 'Check Backend'
@@ -80,7 +81,7 @@ jobs:
           google-service-account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}
 
   build-artifacts:
-    if: "needs.file-changes.outputs.backend == 'true' || needs.file-changes.outputs.ui == 'true'"
+    if: ${{ needs.file-changes.outputs.backend == 'true' || needs.file-changes.outputs.ui == 'true' }}
     name: Build artifacts
     runs-on: ubuntu-latest
     steps: