Add Histogram indicator plot style kernc#195#384
Add Histogram indicator plot style kernc#195#384zlpatel wants to merge 1 commit intokernc:masterfrom
Conversation
|
Great idea to add histograms to the charts. I tested that with many combinations of indicators and it perfectly works. Couldn't find an easy way to use factor_cmap to make one indicator with two colors (let say green for + values and red for - values). To add color horizontal lines at fixed levels is much easier. Thanks for the proposal and will wait to see it in the next official updates. |
|
@zlpatel Thanks for the idea. It is not practical when using standard TA libraries but for some custom indicators is perfect. I had some success using linear_cmap with providing low/high values and their colors. It works good for two colors but is not practical for the squeeze momentum indicator where I will need 4 colors. Anyway, I will try to rewrite all plot parameters for the indicators to have only one dict parameter style, one for each element of the indicator in a list. Then I can select the style for each part of the indicator like for example MACD needs two lines and one histogram. |
@AGG2017 I see what you're saying. I did think about that but couldn't find an easy way to allow multiple style plots into a single indicator. May be we can explore a little more. May be we need to have a new Indicator class which can allow grouping multiple I() in a single plot. |
|
@zlpatel I want just to add one more parameter |
|
3 month passed but code is still not in official repo :( |
7fd493d to
e7981c7
Compare
|
Hi @kernc, It would be great if you could take a look at this one. I think this is the missing piece that everyone is looking for. |
60eff81 to
109c352
Compare
|
I appreciate that @kernc does not want to extend the API to allow charts customization (see this discussion).
I tend to agree that it would be hard to extend the existing Can we tweak the or something even more flexible, so plotting is completely decoupled from the indicators. Thoughts? |
428c361 to
0ce6cab
Compare
70abc06 to
c79ffb0
Compare
RahmanDanial
left a comment
There was a problem hiding this comment.
Your Color & Scatter has error.
added an option
histogram=TrueforI()function. it plots histogram usingvbarfunction of bokeh js.Fixes #195