Fixes for reference before assignment… #18640
Conversation
sachinprasadhs
added
the
keras-team-review-pending
|
Thanks for the PR. Unit tests are failing and the value-add of most of these changes is highly questionable (most of it is unreachable code which will only serve to decrease our coverage). Please double check each change and only keep the useful ones. |
fchollet
removed
the
keras-team-review-pending
keras/optimizers/base_optimizer.py
Outdated
| @@ -602,6 +602,8 @@ def get_config(self): | |||
| learning_rate = serialization_lib.serialize_keras_object( | |||
| self._learning_rate | |||
| ) | |||
| else: | |||
| learning_rate = 0.5 | |||
There was a problem hiding this comment.
Not sure what this should be?
…Close` from `test_tf_data_compatibility` ; [keras/{ops/numpy.py,saving/saving_lib.py}] `black`en
|
@fchollet Hmm ok I'll see what's causing these segfaults. In the meantime a lot of the patches are to solve the traceability problem, i.e., guarantee that the - for output in ds.take(1):
- output = output.numpy()
+ output = next(iter(ds)).numpy()Should I change the PR to just that fix, and make separate PR(s) for the other cases? |
sachinprasadhs
added
the
stat:awaiting keras-eng
|
Hi @SamuelMarks Can you please resolve conflicts? Thank you! |
# Conflicts: # keras/layers/preprocessing/center_crop_test.py # keras/layers/preprocessing/random_crop_test.py # keras/layers/preprocessing/random_rotation_test.py # keras/layers/preprocessing/random_zoom_test.py # keras/layers/preprocessing/resizing_test.py
|
@gbaned - Sure thing. Done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18640 +/- ##
==========================================
+ Coverage 78.85% 81.51% +2.66%
==========================================
Files 513 513
Lines 49250 49259 +9
Branches 9080 7952 -1128
==========================================
+ Hits 38837 40155 +1318
+ Misses 8543 7096 -1447
- Partials 1870 2008 +138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…rop_test,random_crop_test} ops/operation}.py] Resolve issues found through `flake8 --config setup.cfg .`
|
Hi @SamuelMarks Can you please resolve conflicts? Thank you! |
gbaned
added
stat:awaiting response from contributor
and removed
stat:awaiting keras-eng
# Conflicts: # keras/ops/nn.py
|
@gbaned Done |
divyashreepathihalli
added
the
stat:awaiting keras-eng
|
Hi @SamuelMarks Can you please resolve conflicts? Thank you! |
gbaned
added
stat:awaiting response from contributor
and removed
stat:awaiting keras-eng
|
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
# Conflicts: # keras/src/layers/preprocessing/image_preprocessing/random_contrast_test.py # keras/src/layers/preprocessing/image_preprocessing/random_crop_test.py # keras/src/trainers/compile_utils.py
|
@gbaned Sure thing, done |
|
@SamuelMarks , can you check the failing test, looks like some discrepancies in the channel axis. |
|
This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you. |
…py] Return `output_shape` to being dependent on `image_data_format` on `test_tf_data_compatibility`
…py] Return `output_shape` to being dependent on `image_data_format` on `test_tf_data_compatibility`
|
@sachinprasadhs That last commit should do the trick. Also merged in latest |
…rop_test.py] Make tuple `output.shape` for comparison against `output_shape` from `image_data_format` on `test_tf_data_compatibility`
sachinprasadhs
added
the
keras-team-review-pending
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
|
Requisite Spongebob meme: 🎉 it merged! |
found through static analysis tooling
(more to go; or you can merge now and await further PRs; or you can request I move this to one PR per file or per module)