Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example "Train a Vision Transformer on small datasets" from keras 2 to 3 version #1922

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

di-kan
Copy link

@di-kan di-kan commented Aug 31, 2024

I am excited to contribute to this project. This is my first one. I have updated the example from keras 2 to keras 3.

Copy link

google-cla bot commented Aug 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review, this slipped through the cracks. The code looks good! Can you add the generated files?

@di-kan
Copy link
Author

di-kan commented Oct 24, 2024

No worries at all. Of course, I will add the files.
Since I'm new in this, I converted another example (vit_small_ds.py) to version 3, but under the same branch (mine). Should I add those files as well?

@fchollet
Copy link
Member

I converted another example (vit_small_ds.py) to version 3, but under the same branch (mine). Should I add those files as well

Yes, it's fine to do 2 examples in a single PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants