Adding GRPC support to go-sdk #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: unknown <[email protected]>
Signed-off-by: Pranshu Srivastava <[email protected]> Signed-off-by: unknown <[email protected]>
Signed-off-by: unknown <[email protected]>
Signed-off-by: re-Tick <[email protected]> Signed-off-by: unknown <[email protected]>
Signed-off-by: unknown <[email protected]>
PranshuSrivastava
force-pushed
the
grpc_implementation
branch
from
fc78c5a to
1563b09
Compare
Signed-off-by: unknown <[email protected]>
Signed-off-by: unknown <[email protected]>
re-Tick
reviewed
Mar 12, 2023
re-Tick
reviewed
Mar 12, 2023
keploy/keploy.go
Outdated
| k.setKey(r) | ||
| r.Header.Set("Content-Type", "application/json") | ||
| if k.cfg.Server.GrpcEnabled { | ||
| r, err := k.grpcClient.Test(k.Ctx, &proto.TestReq{ |
There was a problem hiding this comment.
Since, there are HTTP and GRPC_EXPORT types of tcs. Therefore, it should have proto.TestReq.GrpcResp field when tcs type is GRPC_EXPORT.
re-Tick
reviewed
Mar 12, 2023
keploy/keploy.go
Outdated
| k.setKey(r) | ||
| r.Header.Set("Content-Type", "application/json") | ||
| if k.cfg.Server.GrpcEnabled { | ||
| _, err = k.grpcClient.DeNoise(k.Ctx, &proto.TestReq{ |
There was a problem hiding this comment.
Here, also it should have proto.TestReq.GrpcResp field assigned when tcs is of type GRPC_EXPORT.
Signed-off-by: unknown <[email protected]>
re-Tick
reviewed
Mar 29, 2023
re-Tick
reviewed
Mar 29, 2023
re-Tick
reviewed
Mar 29, 2023
| _, err = k.grpcClient.DeNoise(k.Ctx, &proto.TestReq{ | ||
| ID: id, | ||
| AppID: k.cfg.App.Name, | ||
| Resp: &proto.HttpResp{ |
There was a problem hiding this comment.
Resp field is empty for testcase of type grpc
re-Tick
reviewed
Mar 29, 2023
keploy/keploy.go
Outdated
| ID: tc.ID, | ||
| AppID: k.cfg.App.Name, | ||
| RunID: runId, | ||
| Resp: &proto.HttpResp{ |
There was a problem hiding this comment.
Please Resp field because this field stores response for http but in grpc, it should be empty.
re-Tick
reviewed
Mar 29, 2023
re-Tick
reviewed
Mar 29, 2023
added 2 commits
March 31, 2023 05:23
o Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
re-Tick
reviewed
Apr 3, 2023
keploy/keploy.go
Outdated
| return nil | ||
| } | ||
| } else { | ||
| url := fmt.Sprintf("%s/regression/testcase?app=%s&offset=%d&limit=%d&testCasePath=%s&mockPath=%s&reqType=%s", k.cfg.Server.URL, k.cfg.App.Name, i, 25, k.cfg.App.TestPath, k.cfg.App.MockPath) |
There was a problem hiding this comment.
Please remove the reqType query parameter.
There was a problem hiding this comment.
Done. PTAL
added 2 commits
April 3, 2023 10:19
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving an option to the user to use either grpc or http while creating tests and mocks. GrpcEnabled field, in the server config will be used to choose one of the options.
Closes #4