Add optional vent holes to lid. #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loved this library. But when I passed "ventHoles=true" to the "enclosureLid" call, nothing changed. I added code to create holes over the pins in the lid when you generate "enclosureLid(ventHoles=true)". This will also make it easier to connect a cased Arduino to outside sensors or actuator controls.
I have printed an Uno lid successfully with this mod, and I examined it on a couple of different wall thicknesses and board types. You know the code better than I do though, so I may not have covered every possibility.