Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keycloak Login Button Label and Icon for Clarity #6

Closed
wants to merge 1 commit into from
Closed

Update Keycloak Login Button Label and Icon for Clarity #6

wants to merge 1 commit into from

Conversation

inderps
Copy link

@inderps inderps commented Sep 20, 2023

Summary
This PR updates the label and icon of the Keycloak login button to better reflect its functionality. The label has been changed from "Sign in with Google" to "Sign in with SSO," and the Google logo has been replaced with a lock icon.

Changes
Updated button label to "Sign in with SSO"
Replaced Google logo with a lock icon

Rationale
The previous label and icon could be misleading, as the button is used for Single Sign-On (SSO) via Keycloak, not specifically for Google authentication. The new label and icon aim to provide a more accurate representation of the button's functionality.

Testing
Manually tested the changes to ensure that the new label and icon appear correctly and that the button still functions as expected.

Feel free to modify this to better suit the project's contribution guidelines or to add any additional information you think might be relevant.

Screenshot 2023-09-20 at 11 52 56

Copy link
Collaborator

@tino097 tino097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunopacheco1
Copy link
Contributor

@JGulic @tino097 kind reminder on this pull request, any idea when it would be integrated to master and released?

@inderps inderps closed this by deleting the head repository Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants