-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor & improvements #42
refactor & improvements #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 72.82% 73.06% +0.24%
==========================================
Files 9 12 +3
Lines 861 995 +134
==========================================
+ Hits 627 727 +100
- Misses 176 206 +30
- Partials 58 62 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a "Testing Done" section to the commit? For large PRs, that's the easiest way to check if all corner cases have been covered.
There are test results one comment above, I've added a summary in the PR |
Contributes to #35
This PR refactors a lot of the code for better structure and better performance of API Calls to AWS.
Testing Done:
see test results in last comment