add debug msg for checksum #295
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 56.20% 55.74% -0.46%
==========================================
Files 14 14
Lines 1893 1896 +3
==========================================
- Hits 1064 1057 -7
- Misses 715 723 +8
- Partials 114 116 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kevdowney
reviewed
Oct 25, 2023
| @@ -126,6 +126,10 @@ func (r *AddonReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl | |||
| return reconcile.Result{}, ignoreNotFound(err) | |||
| } | |||
|
|
|||
| // Log the addon spec and the checksum | |||
| changedStatus, newChecksum := r.validateChecksum(instance) | |||
There was a problem hiding this comment.
This is the first thing we already do in processAddon
addon-manager/controllers/addon_controller.go
Line 239 in ef27eb5
addon-manager/controllers/addon_controller.go
Line 251 in ef27eb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.