Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment marker into api; generate addon clientset/lister/informers #116

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Feb 25, 2022

Fixes:
#97, and it is part of
https://github.intuit.com/kubernetes/arktika/issues/3541

Changes:

  1. move api/v1alpha1 to api/addon/v1alpha1; add "comment marker"
  2. Use code-generator generate API(s) clientset/informer/listers and put into pkg/client directory.
  3. Add code-generator into Makefile generate

Regression:
api_type_tests
controller_tests

@ccfishk ccfishk requested a review from a team as a code owner February 25, 2022 23:00
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
api/addon/register.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ccfishk ccfishk self-assigned this Feb 26, 2022
@ccfishk ccfishk added design enhancement New feature or request and removed design labels Feb 26, 2022
ccfishk pushed a commit that referenced this pull request Feb 27, 2022
Copy link
Collaborator

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccfishk ccfishk merged commit 05e7852 into keikoproj:master Mar 1, 2022
This was referenced Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants