Token added functionality,balance and price of all tokens #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sajalbnl
commented
Oct 27, 2024
sajalbnl
commented
- issue [feat] Fetch account token balances #107 [feat] Update hardcoded token price fetching to use currenly stored tokens #106 [feat] Add a way to save and access token information in the wallet app #87
- follows contribution guide
trbutler4
requested changes
Oct 29, 2024
| // TODO(#106): use the accounts stored tokens instead of hardcoding | ||
| coinViewModel.getTokenPrices(ids = tokens.joinToString(",") { it.name.toLowerCase() }, vsCurrencies = "usd") | ||
|
|
||
| // TODO(#107): fetch all token balances |
| withContext(Dispatchers.Main) { | ||
| balance = weiToEther(getBalance).toDoubleWithTwoDecimal() | ||
| // TODO(#106): use the accounts stored tokens instead of hardcoding | ||
| coinViewModel.getTokenPrices(ids = tokens.joinToString(",") { it.name.toLowerCase() }, vsCurrencies = "usd") |
There was a problem hiding this comment.
'toLowerCase(): String' is deprecated. Use lowercase() instead.
| balance = balances.firstOrNull { balanceMap -> | ||
| balanceMap.containsKey(tokens[index].name) | ||
| }?.get(tokens[index].name)?: "0.0", | ||
| type = tokens[index].symbol.toUpperCase() |
There was a problem hiding this comment.
'toUpperCase(): String' is deprecated. Use uppercase() instead.
| items(tokens.size) { index-> | ||
| WalletCard( | ||
| icon = painterResource(id = R.drawable.ic_ethereum), | ||
| amount = coinsPrices[tokens[index].name]?.let { "$ $it" } ?: "", |
There was a problem hiding this comment.
this is just showing the price per token, it should show the dollar value of the users balance. So this should simply be multiplied by the balance.
| LazyColumn(modifier=Modifier.height(screenHeight)) { | ||
| items(tokens.size) { index-> | ||
| WalletCard( | ||
| icon = painterResource(id = R.drawable.ic_ethereum), |
There was a problem hiding this comment.
can we use an image from coingecko? otherwise we should be looking up the correct image based on the symbol
|
closes #125 |
|
Thank you! great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.