Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Console Output to Indicate Hook Usage in Kedro-Viz #2235

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

rashidakanchwala
Copy link
Contributor

Description

Resolves #2145

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: rashidakanchwala <[email protected]>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rashidakanchwala!

hooks_message = "INFO: Running Kedro-Viz with hooks."
else:
hooks_message = (
"INFO: Running Kedro-Viz without hooks. If you spot missing functionality, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info message If you spot missing functionality seems a bit vague to me. Instead we can say something like -
Running Kedro-Viz without hooks. try kedro viz run --include-hooks to include hook functionality . Wdyt ?

Signed-off-by: rashidakanchwala <[email protected]>
Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rashidakanchwala thank you

@rashidakanchwala rashidakanchwala merged commit e9542ad into main Jan 13, 2025
53 checks passed
@rashidakanchwala rashidakanchwala deleted the add-console-hooks-message branch January 13, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Console Output to Indicate Hook Usage in Kedro-Viz
4 participants