fix: fix waiting to reach failureThreshold before fallback #6520
+0
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change removes a part that used to manually and immediately scale to
Fallback.Replicas
on encountering an error. Scaling to fallback is already done in GetMetricsWithFallback by recording an appropriate metric value the HPA will use, but only afterFallback.FailureThreshold
failures.The current existence of this part causes
Fallback.FailureThreshold
to be effectively unused.doFallbackScaling
andsetFallbackCondition
functions are removed since they are no longer used. The testTestScaleToFallbackReplicasWhenNotActiveAndIsError
is no longer applicable I thinkChecklist