Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix waiting to reach failureThreshold before fallback #6520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

y-rabie
Copy link

@y-rabie y-rabie commented Feb 1, 2025

The change removes a part that used to manually and immediately scale to Fallback.Replicas on encountering an error. Scaling to fallback is already done in GetMetricsWithFallback by recording an appropriate metric value the HPA will use, but only after Fallback.FailureThreshold failures.

The current existence of this part causes Fallback.FailureThreshold to be effectively unused.

doFallbackScaling and setFallbackCondition functions are removed since they are no longer used. The test TestScaleToFallbackReplicasWhenNotActiveAndIsError is no longer applicable I think

Checklist

@y-rabie y-rabie requested a review from a team as a code owner February 1, 2025 21:57
@y-rabie y-rabie force-pushed the fix-fallback-failurethreshold branch from 4157bb4 to 371c33b Compare February 1, 2025 22:05
@y-rabie y-rabie force-pushed the fix-fallback-failurethreshold branch from 371c33b to 2e7aa89 Compare February 1, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant