Fix testLogBug and changeSomeVariableName #6420
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane <[email protected]>
ctccxxd
changed the title
|
Friendly ping @wozniakjan @SpiritZhou @JorTurFer hope you to review and discuss, much thanks. |
JorTurFer
reviewed
Dec 15, 2024
zroubalik
reviewed
Dec 16, 2024
Signed-off-by: Shane <[email protected]>
Signed-off-by: Shane <[email protected]>
Signed-off-by: Shane <[email protected]>
ctccxxd
force-pushed
the
changeSomeVariableNameLog
branch
from
8dd5470 to
f56c05b
Compare
|
done, friendly ping @zroubalik @zroubalik , hope for your review, thank you. |
JorTurFer
approved these changes
Dec 22, 2024
|
/run-e2e internal |
zroubalik
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #
Relates to #