Fix/kafka lagthreshold description #1663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
The lagThreshold parameter description was misleading. Since the Kafka scaler uses AverageValue metric type by default, the HPA algorithm divides the total lag by the number of replicas. Therefore, lagThreshold is an average target value, not the total lag. Fixes kedacore#1653 Signed-off-by: pmady <[email protected]>
pmady
force-pushed
the
fix/kafka-lagthreshold-description
branch
from
adf016c to
49c0db2
Compare
JorTurFer
requested changes
Dec 8, 2025
| - `consumerGroup` - Name of the consumer group used for checking the offset on the topic and processing the related lag. | ||
| - `topic` - Name of the topic on which processing the offset lag. (Optional, see note below) | ||
| - `lagThreshold` - Target value for the total lag (sum of all partition lags) to trigger scaling actions. (Default: `10`, Optional) | ||
| - `lagThreshold` - Average target value to trigger scaling actions. (Default: `10`, Optional) |
Member
There was a problem hiding this comment.
Hello
Could you elaborate this? Although AverageValue is the default metric type (set at scaler level), it can also be Value.
Checking the current scaler code, it sums all the lags per partition and return the total value, so the HPA controller calculates avg or not depending on metric type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #