Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMD-33 - SDS bucket refresh test update #1439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DMD-33 - SDS bucket refresh test update #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 99 additions & 2 deletions tests/Backend/ExternalBuckets/SnowflakeRegisterExternalBucketInSecureDataShareTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ public function testRefreshBucketInLinkedProject(): void
$this->assertCount(2, $linkingTables);
$linkingTable = $linkingTables[0];

$dataPreview = $this->linkingClient->getTableDataPreview($linkingTable['id']);
$dataPreview = $this->linkingClient->getTableDataPreview($linkingTable['id'], ['columns' => ['ID', 'NAME']]);
$this->assertEquals(
<<<EXPECTED
"ID","NAME"
Expand Down Expand Up @@ -351,7 +351,7 @@ function ($tableRow) use ($newTableName) {

$linkedTable = reset($filteredTables);

$dataPreview = $this->linkingClient->getTableDataPreview($linkedTable['id']);
$dataPreview = $this->linkingClient->getTableDataPreview($linkedTable['id'], ['columns' => ['ID', 'NAME']]);
$this->assertEquals(
<<<EXPECTED
"ID","NAME"
Expand Down Expand Up @@ -382,6 +382,103 @@ function ($tableRow) use ($newTableName) {
$result,
);

// check ALTER TABLE
$db = $this->ensureProducerSnowflakeConnection();
$db->executeQuery('USE ROLE ACCOUNTADMIN');
$dbName = $this->getProducerSharedDatabase();
$db->executeQuery(sprintf('USE WAREHOUSE %s', $this->getProducerSnowflakeWarehouse()));

$db->executeQuery(sprintf(
'ALTER TABLE %s.%s ADD COLUMN GENDER STRING DEFAULT \'M\'',
$dbName,
$newTableName,
));

$this->_client->refreshBucket($bucketId);

$refreshedBucket = $this->_client->getBucket($bucketId);
$tableNames = array_map(
function ($tableRow) {
return $tableRow['name'];
},
$refreshedBucket['tables'],
);
$this->assertTrue(in_array($newTableName, $tableNames), 'Altered table not found in refreshed bucket');

$filteredTables = array_filter(
$refreshedBucket['tables'],
function ($tableRow) use ($newTableName) {
return $tableRow['name'] === $newTableName;
},
);

$newTable = reset($filteredTables);

$dataPreview = $this->_client->getTableDataPreview($newTable['id'], ['columns' => ['ID', 'NAME', 'GENDER']]);
$this->assertEquals(
<<<EXPECTED
"ID","NAME","GENDER"
"1","Jan","M"
"2","Josef","M"

EXPECTED,
$dataPreview,
);

$linkingTables = $this->linkingClient->listTables($linkedBucketId);
$this->assertCount(3, $linkingTables);

$linkedBucket = $this->linkingClient->getBucket($linkedBucketId);
$linkedTableNames = array_map(
function ($tableRow) {
return $tableRow['name'];
},
$linkedBucket['tables'],
);
$this->assertTrue(in_array($newTableName, $linkedTableNames), 'Altered table not found in linked bucket after refresh');

$filteredTables = array_filter(
$linkedBucket['tables'],
function ($tableRow) use ($newTableName) {
return $tableRow['name'] === $newTableName;
},
);

$linkedTable = reset($filteredTables);

$dataPreview = $this->linkingClient->getTableDataPreview($linkedTable['id'], ['columns' => ['ID', 'NAME', 'GENDER']]);
$this->assertEquals(
<<<EXPECTED
"ID","NAME","GENDER"
"1","Jan","M"
"2","Josef","M"

EXPECTED,
$dataPreview,
);

// test RO works
$result = $linkingSnowflakeDb->fetchAll(sprintf(
'SELECT * FROM %s.%s',
$linkedBucket['path'],
$newTableName,
));
$this->assertEquals(
[
[
'ID' => 1,
'NAME' => 'Jan',
'GENDER' => 'M',
],
[
'ID' => 2,
'NAME' => 'Josef',
'GENDER' => 'M',
],
],
$result,
);

// CLEANUP

$this->forceUnshareBucketIfExists($this->shareClient, $stage . '.' . $bucketName, true);
Expand Down
Loading