Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1921 Workspace login name #1438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CT-1921 Workspace login name #1438

wants to merge 3 commits into from

Conversation

zajca
Copy link
Member

@zajca zajca commented Jan 22, 2025 •
edited
Loading

Jira: CT-1921
KBC: --

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • New client method(s) support branches, or they are listed in BranchAwareClient
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

Dávám minor přidal sem typehinty do klienta

  • Test that login_name is set for new snowflake workspaces

@zajca zajca added the minor new feature label Jan 22, 2025
@zajca zajca force-pushed the zajca-ct-1921-ws-login-name branch from 6cc0eeb to b812d39 Compare January 22, 2025 13:05
@zajca zajca requested review from a team and jirkasemmler and removed request for a team January 22, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirkasemmler jirkasemmler Awaiting requested review from jirkasemmler jirkasemmler was automatically assigned from keboola/connection

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
minor new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zajca