Backup to google storage #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrajodas
force-pushed
the
PST-2374-ondra
branch
from
ccc4dbc to
d3f61b6
Compare
ondrajodas
force-pushed
the
PST-2374-ondra
branch
from
6dffcff to
3aecad7
Compare
romantmb
approved these changes
Jan 22, 2025
| self::assertGreaterThan(0, count($events)); | ||
| } | ||
|
|
||
| public function testCreateUnexistsBackupFolder(): void |
|
díky, README jsem doplnil |
ErikZigo
reviewed
Jan 22, 2025
Comment on lines
+46
to
+55
| case Config::STORAGE_BACKEND_GCS: | ||
| foreach (['#jsonKey', '#bucket', 'region'] as $item) { | ||
| if (empty($v[$item])) { | ||
| throw new InvalidConfigurationException(sprintf( | ||
| 'Missing required parameter "%s".', | ||
| $item, | ||
| )); | ||
| } | ||
| } | ||
| break; |
There was a problem hiding this comment.
doplnil jsem je 896748c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/PST-2374