Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance AsType a a #149

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

lrworth
Copy link
Contributor

@lrworth lrworth commented Oct 7, 2022

Resolves #146

@JackKelly-Bellroy
Copy link

Is there anything we can do to help move this along?

@Tristano8
Copy link

Gentle bump - would appreciate if this could be reviewed/merged

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this looks good then!

@michaelpj
Copy link
Collaborator

Could you fix the changelog conflict, please?

@lrworth lrworth requested a review from michaelpj April 3, 2024 22:24
@lrworth
Copy link
Contributor Author

lrworth commented Apr 3, 2024

I've updated the wording of AsType and HasType haddocks to permit the reflexive instances, and would like someone to proof-read what I've written.

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads fine to me, thanks!

@michaelpj michaelpj merged commit cbe168c into kcsongor:master Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflexive instances for AsType?
4 participants