Skip to content

refactor: update interval to inherit from term #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: update interval to inherit from term #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pypika/terms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,11 @@ def wrap_constant(

@staticmethod
def wrap_json(
val: Union["Term", "QueryBuilder", "Interval", None, str, int, bool], wrapper_cls=None
) -> Union["Term", "QueryBuilder", "Interval", "NullValue", "ValueWrapper", "JSON"]:
val: Union["Term", "QueryBuilder", None, str, int, bool], wrapper_cls=None
) -> Union["Term", "QueryBuilder", "NullValue", "ValueWrapper", "JSON"]:
from .queries import QueryBuilder

if isinstance(val, (Term, QueryBuilder, Interval)):
if isinstance(val, (Term, QueryBuilder)):
return val
if val is None:
return NullValue()
Expand Down Expand Up @@ -1614,7 +1614,7 @@ def get_special_params_sql(self, **kwargs: Any) -> Optional[str]:
return None


class Interval(Node):
class Interval(Term):
templates = {
# PostgreSQL, Redshift and Vertica require quotes around the expr and unit e.g. INTERVAL '1 week'
Dialects.POSTGRESQL: "INTERVAL '{expr} {unit}'",
Expand Down
Loading