drop support of php 7.x, prepartion of payum/core v2 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Chris53897, that's huge refactoring. We'll need to bump the major version for Payum v2. |
|
@karser GitHub raised an error by creating the PR. After reload it takes longer as normal. I guess that is the reason. |
|
Yes, that would be definitely a new major version. We should wait until those other PRs (Payum/PayumBundle) have been reviewed/merged. On Payum side, there are no updates since 6 months, so I'm really curious about their next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payum/core will have strong types in v.2. I am not sure if php 8.0 or 8.1
Payum/PayumBundle#545
Payum/Payum#943
Maybe this PR could be aligned with v2 of payum/core.