fix: service name and carrier name parsing #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobshilitz
force-pushed
the
eshipper_mapping
branch
from
93945a5
to
2f5839a
Compare
…packages and eShipper XML
jacobshilitz
force-pushed
the
eshipper_mapping
branch
from
2f5839a
to
4a6817c
Compare
|
don't merge before #675 is fixed, becouse in prod this will cause that no service name will show |
danh91
reviewed
Sep 5, 2024
| @@ -29,6 +29,8 @@ def _extract_details( | |||
| service = provider_units.ShippingService.map(str(rate.serviceId)) | |||
| carrierId = provider_units.ShippingService.carrier_id(service.value_or_key) | |||
| rate_provider = provider_units.ShippingService.carrier(service.value_or_key).lower() | |||
| service_name = service.name.replace("eshipper_", "") | |||
There was a problem hiding this comment.
The issue with this is it doesn't take into consideration API changes from eshipper.
If they introduce a new service or carrier that we don't have in the enum, service.name will be None causing an exception.
Essentially, we need to anticipate unexpected data as well.
There was a problem hiding this comment.
correct. I already fixed it on my local... becouse when testing with production it returned only carrier ID
There was a problem hiding this comment.
but I got overwhelmed with the mapping problem
Ensure `service_name` uses `rate.serviceName` as a fallback when `service.name` is not available. This prevents potential attribute errors and ensures consistent naming by replacing spaces with underscores.
|
@danh91 can you recommend what else we need to do to fix the mappings types? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the bug that currently eshipper returns itself as the carrier, and it's different from how it was in the eshipper lagecy XML API, and how other providers that provide multi carrier rates.