(fix) SDK error parsing during SDK request abort

requirements.server.dev.txt

@@ -19,7 +19,7 @@ django-debug-toolbar
 # -e ./sdk/extensions/dicom
 -e ./sdk/extensions/dpd
 # -e ./sdk/extensions/dpdhl
-# -e ./sdk/extensions/fedex
+-e ./sdk/extensions/fedex
 # -e ./sdk/extensions/geodis
 # -e ./sdk/extensions/laposte
 # -e ./sdk/extensions/nationex
@@ -56,7 +56,7 @@ karrio.dhl-universal
 karrio.dicom
 # karrio.dpd
 karrio.dpdhl
-karrio.fedex
+# karrio.fedex
 karrio.geodis
 karrio.laposte
 karrio.nationex

sdk/core/karrio/api/interface.py

@@ -27,6 +27,10 @@ def abort(
     Returns:
         Tuple[None, List[models.Message]]: a tuple of empty response and a list or error messages
     """
+
+    if isinstance(error, errors.ParsedMessagesError):
+        return None, error.messages
+
     return (
         None,
         [

sdk/core/karrio/core/errors.py

@@ -1,17 +1,8 @@
 """Karrio Custom Errors(Exception) definition modules"""
-import warnings
 from enum import Enum
 from typing import Dict
 
 
-class DeprecatedClass:
-    deprecation_message = "This class is deprecated and will be removed soon"
-
-    def __init__(self, *args, **kwargs):
-        warnings.warn(self.deprecation_message, DeprecationWarning)
-        super().__init__(*args, **kwargs)
-
-
 class FieldErrorCode(Enum):
     required = dict(code="required", message="This field is required")
     invalid = dict(code="invalid", message="This field is invalid")
@@ -27,8 +18,8 @@ class ShippingSDKError(Exception):
 class ShippingSDKDetailedError(ShippingSDKError):
     """Base class for other exceptions."""
 
-    def __init__(self, *args):
-        self.details = None
+    def __init__(self, *args, details=None):
+        self.details = details
         super().__init__(*args)
 
 
@@ -42,6 +33,16 @@ def __init__(self, fields: Dict[str, FieldErrorCode]):
         self.details = {name: code.value for name, code in fields.items()}
 
 
+class ParsedMessagesError(ShippingSDKDetailedError):
+    """Raised when one or many required fields are missing."""
+
+    code = "SHIPPING_SDK_FIELD_ERROR"
+
+    def __init__(self, messages = []):
+        super().__init__("Invalid request payload")
+        self.messages = messages
+
+
 class ValidationError(ShippingSDKError):
     """Base class for other exceptions."""
 
@@ -82,21 +83,3 @@ class MultiParcelNotSupportedError(ShippingSDKError):
 
     def __init__(self):
         super().__init__(f"Multi-parcel shipment not supported")
-
-
-"""Deprecated Custom Errors"""
-
-
-class PurplShipError(Exception, DeprecatedClass):
-    """Base class for other exceptions."""
-
-    code = "SHIPPING_SDK_INTERNAL_ERROR"
-    deprecation_message = "PurplShipError is deprecated and will be removed soon. use ShippingSDKError instead"
-
-
-class PurplShipDetailedError(PurplShipError):
-    """Base class for other exceptions."""
-
-    def __init__(self, *args):
-        self.details = None
-        super().__init__(*args)

sdk/extensions/boxknight/karrio/providers/boxknight/utils.py

@@ -1,6 +1,7 @@
 import jstruct
 import karrio.lib as lib
 import karrio.core as core
+import karrio.core.errors as errors
 
 
 class Settings(core.Settings):
@@ -52,9 +53,9 @@ def authenticate(settings: Settings):
         method="POST",
     )
     response = lib.to_dict(result)
-    errors = error.parse_error_response(response, settings)
+    messages = error.parse_error_response(response, settings)
 
-    if any(errors):
-        raise Exception(errors)
+    if any(messages):
+        raise errors.ParsedMessagesError(messages=messages)
 
     return dict(token=response["token"])

sdk/extensions/dpd/karrio/providers/dpd/utils.py

@@ -1,9 +1,11 @@
 import dpd_lib.Authentication20 as auth
 import dpd_lib.LoginServiceV21 as dpd
+
 import jstruct
 import datetime
 import karrio.lib as lib
 import karrio.core as core
+import karrio.core.errors as errors
 
 
 class Settings(core.Settings):
@@ -108,10 +110,10 @@ def login(settings: Settings):
         },
     )
     response = lib.to_element(result)
-    errors = error.parse_error_response(response, settings)
+    messages = error.parse_error_response(response, settings)
 
-    if any(errors):
-        raise Exception(errors)
+    if any(messages):
+        raise errors.ParsedMessagesError(messages=messages)
 
     return _extract_login_details(response)
 

sdk/extensions/ups/karrio/providers/ups/utils.py

@@ -97,7 +97,7 @@ def login(settings: Settings):
     messages = error.parse_error_response(response, settings)
 
     if any(messages):
-        raise errors.ShippingSDKError(messages)
+        raise errors.ParsedMessagesError(messages=messages)
 
     expiry = datetime.datetime.fromtimestamp(
         float(response.get("issued_at")) / 1000