Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct loss calc from SSE to MSE in backprop loop #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct loss calc from SSE to MSE in backprop loop #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lectures/micrograd/micrograd_lecture_second_half_roughly.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,7 @@
" \n",
" # forward pass\n",
" ypred = [n(x) for x in xs]\n",
" loss = sum((yout - ygt)**2 for ygt, yout in zip(ys, ypred))\n",
" loss = sum((yout - ygt)**2 for ygt, yout in zip(ys, ypred)) / len(ys) # Video lecture calculates loss as SSE. Corrected to MSE here.\n",
" \n",
" # backward pass\n",
" for p in n.parameters():\n",
Expand Down