-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmada-webhook: fix the no such host error #6079
base: master
Are you sure you want to change the base?
Conversation
0a43f08
to
6e508a6
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6079 +/- ##
==========================================
+ Coverage 48.33% 48.35% +0.01%
==========================================
Files 666 666
Lines 54874 54908 +34
==========================================
+ Hits 26525 26549 +24
- Misses 26623 26631 +8
- Partials 1726 1728 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6e508a6
to
063ccfd
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhzhuang-zju <[email protected]>
063ccfd
to
61b4b4c
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
when deploying karmada instance by operator or
karmadactl init
,karmada-apiserver will reportdial tcp: lookup karmada-webhook.karmada-system.svc on x.x.x.x: no such host
error if the namespace of karmada instance is notkarmada-system
.karmada/charts/karmada/_crds/patches/webhook_in_resourcebindings.yaml
Lines 1 to 14 in 211351b
The webhook url is hardcoded and actually needs to be entered via a variable.
Which issue(s) this PR fixes:
Fixes #4893
Special notes for your reviewer:
Does this PR introduce a user-facing change?: