-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add automatic memory limit handling #6059
base: master
Are you sure you want to change the base?
feat: Add automatic memory limit handling #6059
Conversation
Signed-off-by: dongjiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6059 +/- ##
==========================================
- Coverage 48.36% 48.35% -0.02%
==========================================
Files 666 667 +1
Lines 54842 54898 +56
==========================================
+ Hits 26527 26546 +19
- Misses 26595 26631 +36
- Partials 1720 1721 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@dongjiang1989 Using |
What type of PR is this?
What this PR does / why we need it:
Enable automatic detection of memory limits and configure GOMEMLIMIT to match.Also includes a flag to allow controlling the reserved ratio.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: