Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom karmada component flags #6056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind api-change
/kind deprecation

What this PR does / why we need it

Karmada components offer a multitude of customizable features through flags, such as feature gates, allowing users to tailor their Karmada cluster according to their specific needs. Currently, the karmada-operator supports implementing these functionalities via fields like extraArgs, but:

  • API spec.featuregates, spec.components.<component>.featureGates and spec.components.<component>.extraArgs all can be used to customize the component's featureGates. However, an excess of configurable options can confuse users and present challenges for future code maintenance.

  • Component local etcd does not support the aforementioned capabilities.

  • The previous implementation has some legacy items.

Based on these considerations, I referred to the kubeadm implementation and made modifications to it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- The following fields in `Karmada` API are deprecated and will be removed from the following releases:
  * `KarmadaSpec.FeatureGates`
  * `KarmadaAPIServer.ExtraArgs`
  * `KarmadaAPIServer.FeatureGates`
  * `KarmadaAggregatedAPIServer.ExtraArgs`
  * `KarmadaAggregatedAPIServer.FeatureGates`
  * `KubeControllerManager.ExtraArgs`
  * `KubeControllerManager.FeatureGates`
  * `KarmadaControllerManager.ExtraArgs`
  * `KarmadaControllerManager.FeatureGates`
  * `KarmadaScheduler.ExtraArgs`
  * `KarmadaScheduler.FeatureGates`
  * `KarmadaDescheduler.ExtraArgs`
  * `KarmadaSearch.ExtraArgs`
  * `KarmadaMetricsAdapter.ExtraArgs`
  * `KarmadaWebhook.ExtraArgs`
- Introduced `ExtraFlags` to `Karmada` API to custom karmada component flags

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 16, 2025
@karmada-bot karmada-bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Jan 16, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign poor12, rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 16, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.71429% with 22 lines in your changes missing coverage. Please review.

Project coverage is 48.33%. Comparing base (9a30bc9) to head (a096b78).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/util/patcher/pather.go 35.29% 20 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6056      +/-   ##
==========================================
- Coverage   48.36%   48.33%   -0.03%     
==========================================
  Files         666      666              
  Lines       54842    54883      +41     
==========================================
+ Hits        26523    26530       +7     
- Misses      26598    26628      +30     
- Partials     1721     1725       +4     
Flag Coverage Δ
unittests 48.33% <60.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

cc @calvin0327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants