feat : add cluster registration step in pull mode to installation-chart.yaml

[SkySingh04]

Signed-off-by: Akash [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Parts of #5916

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• .github/workflows/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (5bfdf61) to head (812091d).
Report is 21 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6007      +/-   ##
==========================================
- Coverage   48.33%   48.11%   -0.22%     
==========================================
  Files         666      668       +2     
  Lines       54858    55163     +305     
==========================================
+ Hits        26516    26543      +27     
- Misses      26617    26894     +277     
- Partials     1725     1726       +1     

Flag	Coverage Δ
unittests	48.11% <ø> (-0.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhzhuang-zju]

@SkySingh04 The ci has failed, which is the same issue mentioned in #6006.

Can you also change Fixes to Parts of? Fixes is commonly used in scenarios where one issue corresponds to one pull request (PR). When an issue requires multiple PRs to resolve, setting it as Fixes may lead to the issue being incorrectly closed.

[SkySingh04]

Hey @zhzhuang-zju , I am getting

error: couldn't validate the identity of the API Server: Get "https://https/172.18.0.5:6443/api/v1/namespaces/kube-public/configmaps/cluster-info?timeout=10s": dial tcp: lookup https on 127.0.0.53:53: server misbehaving

upon running the register command in the CI. Got any pointers that could help out?

[zhzhuang-zju]

@SkySingh04 The reason for the failure is that the context used when executing the register command was karmada-host. When Helm installed Karmada, it did not generate the kubeconfig file for karmada-apiserver, which requires us to manually create it.

It seems there are many subtle yet crucial points in this task that are easy to overlook. I will fully implement it locally first, and you can wait for me to complete the local implementation before making the corresponding modifications based on it.

[SkySingh04]

Sure @zhzhuang-zju , Looking forward to working with you on this!

[zhzhuang-zju]

During local verification, I found that after installing Karmada via Helm and executing the register command to register a cluster in pull mode, I still need to manually modify the server field in the kubeconfig and the ConfigMap cluster-info. Although the problem can be solved with a script, it's not very generic. Referring to #3536 (comment) and #3657, there are already relevant issues and PRs in the community, but there hasn't been much progress. I'll try to push it forward first.