Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Priority and PreemptionPolicy fields in ResourceBinding #5963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Add Priority and PreemptionPolicy fields in ResourceBinding to support priority-based scheduling. This enables:

  • Priority-based scheduling for ResourceBindings
  • Preemption control through PreemptionPolicy
  • Better control over scheduling order of workloads across clusters

Which issue(s) this PR fixes:
Part of #5961

Special notes for your reviewer:

  • Priority field is added as int32 to align with Kubernetes conventions
  • PreemptionPolicy supports two modes: Never (default) and PreemptLowerPriority

Does this PR introduce a user-facing change?:

Add Priority and PreemptionPolicy fields to ResourceBinding API to support priority-based scheduling and preemption control.
- Priority: Defines scheduling priority (higher values = higher priority)
- PreemptionPolicy: Controls whether binding can preempt lower priority bindings

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Dec 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2024
// Bindings with higher priority values are scheduled ahead of bindings with lower priority values.
// If not specified, the priority value is set to 0.
// +optional
Priority int32 `json:"priority,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't allow the user to override the priority in the binding, and the priority value can only be derived by the priority class, I use int32 instead of *int32 for now. Open to discussion.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.17%. Comparing base (8d89d77) to head (9ceb28b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5963   +/-   ##
=======================================
  Coverage   48.17%   48.17%           
=======================================
  Files         664      664           
  Lines       54799    54799           
=======================================
+ Hits        26399    26400    +1     
  Misses      26684    26684           
+ Partials     1716     1715    -1     
Flag Coverage Δ
unittests 48.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants