-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Priority and PreemptionPolicy fields in ResourceBinding #5963
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// Bindings with higher priority values are scheduled ahead of bindings with lower priority values. | ||
// If not specified, the priority value is set to 0. | ||
// +optional | ||
Priority int32 `json:"priority,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't allow the user to override the priority in the binding, and the priority value can only be derived by the priority class, I use int32
instead of *int32
for now. Open to discussion.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5963 +/- ##
=======================================
Coverage 48.17% 48.17%
=======================================
Files 664 664
Lines 54799 54799
=======================================
+ Hits 26399 26400 +1
Misses 26684 26684
+ Partials 1716 1715 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wei-chenglai <[email protected]>
6b8fdc4
to
9ceb28b
Compare
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Add Priority and PreemptionPolicy fields in ResourceBinding to support priority-based scheduling. This enables:
Which issue(s) this PR fixes:
Part of #5961
Special notes for your reviewer:
Does this PR introduce a user-facing change?: