Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for parsing static value with parseJSONValue func #5959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test case for parsing static value with parseJSONValue func #5959

wants to merge 1 commit into from

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add a new test case for parsing static value with parseJSONValue func, refer to #5788 (comment)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 17, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Parse static value with parseJSONValue func Add test case for parsing static value with parseJSONValue func Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.17%. Comparing base (5fbcf9b) to head (c01dd9a).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5959      +/-   ##
==========================================
- Coverage   48.18%   48.17%   -0.01%     
==========================================
  Files         664      664              
  Lines       54799    54799              
==========================================
- Hits        26405    26401       -4     
- Misses      26680    26683       +3     
- Partials     1714     1715       +1
Flag Coverage Δ
unittests 48.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhzhuang-zju
zhzhuang-zju reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, others LGTM

pkg/controllers/applicationfailover/common_test.go
@@ -226,6 +226,15 @@ func Test_parseJSONValue(t *testing.T) {
wantErr: assert.NoError,
want: "2",
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a comment describing what the test case does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get it from the test case get a static value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update with get a static value just as jsonPath write

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the parse-static-value-with-parse-json branch from 0210929 to c01dd9a Compare December 17, 2024 12:25
@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
RainbowMango
RainbowMango reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
This behavior looks weird and still under discussion. Let's hold for a while.
See #5788 (comment).

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@RainbowMango RainbowMango RainbowMango left review comments

@jwcesign jwcesign Awaiting requested review from jwcesign

@whitewindmills whitewindmills Awaiting requested review from whitewindmills

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XiShanYongYe-Chang @karmada-bot @codecov-commenter @zhzhuang-zju @RainbowMango