Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto create pr to update helm index when release chart #5911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Dec 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Auto create pr to update helm index when release chart.

You can see the effective demonstration in my personal repo:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I investigated the helm/chart-releaser-action. It generates Helm chart releases and updates the chart index on the gh-pages branch, but this is not what we need:

  • We already have ci process to generate and upload chart release assets, we don't need another ci to do the same thing.
  • That chart-releaser-action still need someone to submit a pr to update charts/karmada/Chart.yaml, in order to trigger the process of this action. However, I think it would be better if the operation of update index can be just right triggered by publishing release without anyone manually submit any pr.
  • That chart-releaser-action requires a additional branch gh-pages.

So, we just only need a CI process that automatically updates the chart index when a new release is published.

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liangyuanpeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2024
@chaosi-zju
Copy link
Member Author

Attention: to run this action in workflow, the workflow permissions of Allow GitHub Actions to create and approve pull requests should be opened.

image

@chaosi-zju
Copy link
Member Author

hi @a7i , can you give some advices on this PR, thank you very much~

@chaosi-zju chaosi-zju force-pushed the master branch 2 times, most recently from faf068f to 607b6c0 Compare December 6, 2024 08:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.95%. Comparing base (a655c45) to head (1d7f466).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5911      +/-   ##
==========================================
+ Coverage   47.86%   47.95%   +0.08%     
==========================================
  Files         663      663              
  Lines       54761    54769       +8     
==========================================
+ Hits        26210    26262      +52     
+ Misses      26845    26801      -44     
  Partials     1706     1706              
Flag Coverage Δ
unittests 47.95% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a7i
Copy link
Contributor

a7i commented Dec 7, 2024

/lgtm 🏆

hack/update-chart-index.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

@RainbowMango So, you prefer how we move this forward, is add hack/update-chart-index.sh to Build Release pipeline, or I just write a website doc like (cherry-picks )[https://karmada.io/docs/contributor/cherry-picks] about how to use hack/update-chart-index.sh to auto create a PR to update chart index?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants