-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl: unit test deinit #5830
base: master
Are you sure you want to change the base?
pkg/karmadactl: unit test deinit #5830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5830 +/- ##
==========================================
+ Coverage 45.56% 46.11% +0.55%
==========================================
Files 658 659 +1
Lines 53926 53957 +31
==========================================
+ Hits 24569 24883 +314
+ Misses 27752 27434 -318
- Partials 1605 1640 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other LGTM
/assign |
In this commit, we unit test deinit in karmadactl on deleting all components related to karmada after it was initialized using init. Signed-off-by: Mohamed Awnallah <[email protected]>
3850109
to
0f584aa
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test deinit in karmadactl on deleting all components related to karmada after it was initialized using init.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: