-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resources to webhook chart #3891
Conversation
/assign |
@yizhang-zen Do you test this change? |
No, I didn't. What are the steps to test out? |
Hello, thank you for your pull request~
Best wishes~ |
8cbb702
to
5e89dbb
Compare
Thank you, @chaosi-zju
No, just keep the same name output as other components' chart (aggregated apiserver and karmada apiserver for example).
Added:) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3891 +/- ##
==========================================
- Coverage 51.87% 51.86% -0.02%
==========================================
Files 243 243
Lines 24112 24112
==========================================
- Hits 12509 12506 -3
- Misses 10921 10923 +2
- Partials 682 683 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@chaosi-zju can you help to take a look at this PR. This reminds me we should enable chart installation in CI. @yizhang-zen I'm sorry for letting this PR wait so long. Can you help to rebase your PR? Because the test suites now might be different from the master branch. |
Signed-off-by: yizhang-zen <[email protected]>
Signed-off-by: yizhang-zen <[email protected]>
5e89dbb
to
f53a47d
Compare
You are good. I updated my pr just recently and this is not urgent at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to chart owners to take another look.
/assign @chaosi-zju @calvin0327 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Does webhook need livenessProbe?
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: