Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resources to webhook chart #3891

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

yizhang-zen
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

  • add resources to webhook chart
  • add descheduler as part of container's name

Does webhook need livenessProbe?

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
@calvin0327
Copy link

/assign

@calvin0327
Copy link

@yizhang-zen Do you test this change?

@yizhang-zen
Copy link
Contributor Author

@yizhang-zen Do you test this change?

No, I didn't. What are the steps to test out?

@chaosi-zju
Copy link
Member

chaosi-zju commented Aug 7, 2023

Hello, thank you for your pull request~

  1. I wanna to known why you want to add descheduler as part of container's name? Are there any scenes that must be like this?

  2. If you want to test this change, I think you can refer to Installing the chart and test it by local installation, then you shall observe if the installation was successful and whether the rename and add resource op done as you expected.

  3. I really appreciate it that you add the resources to the chart, further more, it seems like the same bug exist in karmada-scheduler-estimator, could you please help us to fix it too?

Best wishes~

@yizhang-zen
Copy link
Contributor Author

Thank you, @chaosi-zju

I wanna to known why you want to add descheduler as part of container's name? Are there any scenes that must be like this?

No, just keep the same name output as other components' chart (aggregated apiserver and karmada apiserver for example).

it seems like the same bug exist in karmada-scheduler-estimator, could you please help us to fix it too?

Added:)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2989cc) 51.87% compared to head (5e89dbb) 51.86%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.02%     
==========================================
  Files         243      243              
  Lines       24112    24112              
==========================================
- Hits        12509    12506       -3     
- Misses      10921    10923       +2     
- Partials      682      683       +1     
Flag Coverage Δ
unittests 51.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

@chaosi-zju can you help to take a look at this PR. This reminds me we should enable chart installation in CI.

@yizhang-zen I'm sorry for letting this PR wait so long. Can you help to rebase your PR? Because the test suites now might be different from the master branch.

@yizhang-zen
Copy link
Contributor Author

@yizhang-zen I'm sorry for letting this PR wait so long. Can you help to rebase your PR? Because the test suites now might be different from the master branch.

You are good. I updated my pr just recently and this is not urgent at all.
I have rebased my PR

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave LGTM to chart owners to take another look.

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@RainbowMango RainbowMango added this to the v1.9 milestone Dec 8, 2023
@RainbowMango RainbowMango added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2023
@RainbowMango
Copy link
Member

/assign @chaosi-zju @calvin0327

@chaosi-zju
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2023
@karmada-bot karmada-bot merged commit fdbb322 into karmada-io:master Dec 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants