Add an optional environment variable for docker images in order to easily and globally configure additional startup flags #2649
Conversation
| @@ -16,6 +16,7 @@ if [ -z "$KARATE_SOCAT_START" ] | |||
| export KARATE_SOCAT_START="true" | |||
| export KARATE_CHROME_PORT="9223" | |||
| fi | |||
| [ -z "$KARATE_BROWSER_ADDITIONAL_FLAGS" ] && export KARATE_BROWSER_ADDITIONAL_FLAGS="" | |||
There was a problem hiding this comment.
sorry for the delay, can we rename to KARATE_CHROME_ADD_OPTIONS just to be similar to the driver option key name here: https://github.com/karatelabs/karate/tree/master/karate-core#configure-driver
else I think this is good to go will merge 👍
There was a problem hiding this comment.
I appreciate your point on having the name generic, I do feel that it is not practical to normalize the command line options for all browsers and the images are likely to remain browser specific, e.g. karate-chrome.
on second thoughts, KARATE_ADD_OPTIIONS should be good enough. sorry I tend to be fussy about names, but you can take a final call
There was a problem hiding this comment.
KARATE_DRIVER_ADD_OPTIONS should be good I think
There was a problem hiding this comment.
actually no, DRIVER is client and end executable is browser. you can choose between KARATE_CHROME_ADD_OPTIONS and KARATE_BROWSER_ADD_OPTIONS
There was a problem hiding this comment.
no worries i agree that naming is important. let's go with KARATE_CHROME_ADD_OPTIONS if the images will stay chrome specific.
There was a problem hiding this comment.
i added a new commit with new name change
Description
Add an optional environment variable in karate docker images that when set add its value as additional flags to browsers' startup command.