Bug7263/pmix setup app api #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function should help to check the max size of env value before append the new one
|
@artpol84, please review |
artpol84
suggested changes
Dec 5, 2020
| @@ -209,6 +211,7 @@ extern mpi_plugin_client_state_t *p_mpi_hook_client_prelaunch( | |||
| static bool setup_done = false; | |||
| uint32_t nnodes, ntasks, **tids; | |||
| uint16_t *task_cnt; | |||
| char *process_mapping = NULL; | |||
There was a problem hiding this comment.
Suggested change
| char *process_mapping = NULL; |
Comment on lines
239
to
+240
| setenvf(env, PMIXP_SLURM_MAPPING_ENV, "%s", process_mapping); | ||
| xfree(process_mapping); |
There was a problem hiding this comment.
Suggested change
| setenvf(env, PMIXP_SLURM_MAPPING_ENV, "%s", process_mapping); | |
| xfree(process_mapping); |
| @@ -631,9 +635,141 @@ int pmixp_mkdir(char *path, mode_t rights) | |||
| return errno; | |||
| } | |||
|
|
|||
| if (chown(path, (uid_t) pmixp_info_jobuid(), (gid_t) -1) < 0) { | |||
There was a problem hiding this comment.
Why can't we use pmixp_info_jobuid() but inside it return the correct value?
This is what pmixp_info is for
|
|
||
| static inline int pmixp_info_timeout(void) | ||
| { | ||
| xassert(_pmixp_job_info.magic == PMIXP_INFO_MAGIC); | ||
| return _pmixp_job_info.timeout; | ||
| xassert(_pmixp_stepd_info.proc_info.magic == PMIXP_INFO_MAGIC); |
There was a problem hiding this comment.
Let's move all static functions to the pmixp_info.c as Danny asked long time ago.
| #ifdef PMIX_SERVER_TMPDIR | ||
| PMIXP_KVP_ADD(kvp, PMIX_SERVER_TMPDIR, | ||
| pmixp_info_tmpdir_lib(), PMIX_STRING); |
There was a problem hiding this comment.
The job of pmixp_info_tmpdir_lib() is to return the proper value.
I don't see why we need to change function prototypes instead of adjusting pmixp_info to accommodate srun.
| @@ -51,6 +51,11 @@ typedef struct { | |||
| #endif | |||
| char nspace[PMIXP_MAX_NSLEN]; | |||
| slurm_step_id_t step_id; /* Current step id (or NO_VAL) */ | |||
| char *lib_tmpdir; | |||
There was a problem hiding this comment.
Suggested change
| char *lib_tmpdir; | |
| uint32_t nnodes; /* number of nodes in current step */ | |
| uint32_t nnodes_job; /* number of nodes in current job */ | |
| uint32_t ntasks; /* total number of tasks in current step */ | |
| char *lib_tmpdir; | |
| char *spool_dir; | |
| uid_t uid; | |
| gid_t gid; |
Comment on lines
76
to
78
| char *spool_dir; | ||
| uid_t uid; | ||
| gid_t gid; |
There was a problem hiding this comment.
Suggested change
| char *spool_dir; | |
| uid_t uid; | |
| gid_t gid; |
Comment on lines
59
to
61
| uint32_t nnodes; /* number of nodes in current step */ | ||
| uint32_t nnodes_job; /* number of nodes in current job */ | ||
| uint32_t ntasks; /* total number of tasks in current step */ |
There was a problem hiding this comment.
Suggested change
| uint32_t nnodes; /* number of nodes in current step */ | |
| uint32_t nnodes_job; /* number of nodes in current job */ | |
| uint32_t ntasks; /* total number of tasks in current step */ |
| int pmixp_srun_init(const mpi_plugin_client_info_t *job, char ***env) | ||
| { | ||
| int rc; | ||
|
|
There was a problem hiding this comment.
As we discussed, proc mapping generation should go here!
| @@ -1283,7 +1311,8 @@ int pmixp_server_direct_conn_early(void) | |||
|
|
|||
| PMIXP_DEBUG("called"); | |||
| proc.rank = pmixp_lib_get_wildcard(); | |||
| strncpy(proc.nspace, _pmixp_job_info.nspace, PMIXP_MAX_NSLEN); | |||
| strncpy(proc.nspace, _pmixp_stepd_info.proc_info.nspace, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.