Use MP4 average frame duration for M3U8 playlist FRAME-RATE calculation #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of MP4 videos have frames daration less than average frame duration, which leads to big FRAME-RATE values in M3U8 playlists.
This pull request offers to use average frame duation for FRAME-RATE into M3U8 playlists for MP4
EXAMPLE:
Current logic:
#EXTM3U #EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1662071,RESOLUTION=480x854,FRAME-RATE=573.248,CODECS="avc1.64001f,mp4a.40.2",VIDEO-RANGE=SDR ./index-f1-v1-a1.m3u8 #EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=843389,RESOLUTION=360x640,FRAME-RATE=573.248,CODECS="avc1.64001e,mp4a.40.2",VIDEO-RANGE=SDR ./index-f2-v1-a1.m3u8New logic:
#EXTM3U #EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1662071,RESOLUTION=480x854,FRAME-RATE=30.060,CODECS="avc1.64001f,mp4a.40.2",VIDEO-RANGE=SDR ./index-f1-v1-a1.m3u8 #EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=843389,RESOLUTION=360x640,FRAME-RATE=30.060,CODECS="avc1.64001e,mp4a.40.2",VIDEO-RANGE=SDR ./index-f2-v1-a1.m3u8