dkms: Suggest trusting the git directory if version detection failed

Git 2.35.2 added a trust model to prevent user scripts and hooks of git repositories to be executed with elevated privileges by accident. This prevents the installer from getting the repository version when the repository was checked out by a non-root user. This commit adds an error message to suggest trusting the repository and also links to the bug report for further details. Fixes: atar-axis#346 Signed-off-by: Kai Krakow <[email protected]>
kakra · May 25, 2022 · 3928a70 · 3928a70
1 parent 580de38
commit 3928a70
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/installer.sh b/lib/installer.sh
@@ -9,7 +9,13 @@ fi
 GIT_ROOT=$(git rev-parse --show-toplevel 2>/dev/null || true)
 
 __version() {
-	git describe --tags --dirty 2>/dev/null || sed -re's/v?(.*)/v\1/' "$(dirname "${BASH_SOURCE[0]}")/../VERSION"
+	git describe --tags --dirty 2>/dev/null || sed -re's/v?(.*)/v\1/' "$(dirname "${BASH_SOURCE[0]}")/../VERSION" || {
+		echo >&2 "ERROR: If you install from a git repository, you may need to run"
+		echo >&2 "ERROR: sudo git config --global --add safe.directory \$PWD"
+		echo >&2 "ERROR: to trust this git checkout for the root user."
+		echo >&2 "ERROR: See https://github.com/atar-axis/xpadneo/issues/346"
+		exit 3
+	}
 }
 
 __version_lte() {