perf(grpc): switch to gRPC CodecV2 for improved performance #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 80.14% 80.07% -0.07%
==========================================
Files 179 179
Lines 21548 21563 +15
==========================================
- Hits 17269 17266 -3
- Misses 3497 3511 +14
- Partials 782 786 +4 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
use_grpc_codec_v2
branch
2 times, most recently
from
6e38c0c to
859ee20
Compare
ijsong
changed the base branch from
main
to
testutil_add_unit_tests_and_remove_unused_functions
hungryjang
reviewed
Feb 1, 2025
hungryjang
approved these changes
Feb 3, 2025
ijsong
force-pushed
the
testutil_add_unit_tests_and_remove_unused_functions
branch
from
fc72ef5 to
c9d5fa8
Compare
ijsong
force-pushed
the
use_grpc_codec_v2
branch
from
859ee20 to
620cb18
Compare
ijsong
force-pushed
the
testutil_add_unit_tests_and_remove_unused_functions
branch
from
c9d5fa8 to
2f859d2
Compare
ijsong
force-pushed
the
use_grpc_codec_v2
branch
from
620cb18 to
9ee82d7
Compare
Base automatically changed from
testutil_add_unit_tests_and_remove_unused_functions
to
main
February 3, 2025 12:17
ijsong
force-pushed
the
use_grpc_codec_v2
branch
from
9ee82d7 to
101fbbc
Compare
This PR updates the gRPC codec from v1 to v2, enhancing performance and reducing memory allocations by utilizing a memory pool for encoded messages. Refs: - grpc/grpc-go#7356 - vitessio/vitess#16790
ijsong
force-pushed
the
use_grpc_codec_v2
branch
from
101fbbc to
e7002e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the gRPC codec from v1 to v2, enhancing performance and reducing
memory allocations by utilizing a memory pool for encoded messages.
Refs:
mem.BufferSliceinstead of[]bytegrpc/grpc-go#7356