consensus/istanbul: Deduplicate ValSet logic in consensus #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yRound|GetProposerByRound
tnasu
force-pushed
the
dev-consensus-refactor
branch
from
7265256 to
a955240
Compare
yoomee1313
reviewed
Jan 23, 2026
| } | ||
|
|
||
| return sb.GetCommitteeStateByRound(num, uint64(header.Round())) | ||
| return sb.committeeStateProvider.GetValidatorSet(num) |
Contributor
There was a problem hiding this comment.
How's about adding getQualifiedValidators at kaiax/valset module interface?
| backlogsMu *sync.Mutex | ||
|
|
||
| currentCommittee *istanbul.RoundCommitteeState | ||
| current *roundState |
Contributor
There was a problem hiding this comment.
I have an idea. How's about adding the qualified, committee, proposer, committeeSize inside the current roundState?
| committeeSizeGauge metrics.Gauge | ||
|
|
||
| // Committee state provider | ||
| committeeStateProvider consensus.CommitteeStateProviderInterface |
Contributor
There was a problem hiding this comment.
On second thought, i think it would be better to inject the valset and the govModule. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some validator-related functions are duplicated, and these do not need the interfaces in the
consensuspackage. If those functions can be used directly via eachkaiaxmodule, they can be removed from theistanbul.Backedinterface.Changes:
istanbul.BackedinterfaceGetProposer,GetCommitteeState,GetValidatorSet,GetCommitteeStateByRound,GetProposerByRoundbackend.backendimplementationGetProposer: Remove because there is no usage in production. Use existing testcase usage only: b273293GetCommitteeState: Convert to a private function because it is used for thebackend.GetConsensusInfo(consensus/istanbul/backend)function only: d9c3d53getRewardAddressis also the same reasonGetValidatorSet,GetCommitteeStateByRound,GetProposerByRoundconsensuspackage, so they cannot be removed/changedcorepackage logics because core accesses them via theistanbul.Backendinterface: a6de335committeeStateProvideror notcommitteeStateProviderfor use anywhere: 098c23bcommitteeStateProviderfrom thecorepackage logics: ba9eaeaTypes of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments