Block read cache #758
Open
Block read cache #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 13, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 13, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 13, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 13, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 16, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 16, 2024
voyvodov
added a commit
to voyvodov/goofys
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a block read cache mode, which essentially divides the file into blocks that are managed by an LRU cache. Cache size is currently fixed at startup. All opened files share the same cache structure. Serial read performance is maintained via read ahead on the block-level cache. Random access performance improves a lot, which can be further improved via parallel read (using different fds) on the same file. The code is also cleaner and supposedly more robust and easier to maintain because we no longer need the buffer pool.
This new mode serves my use case well. I am not sure if anyone else is interested in this. Feedback is welcome.