Update instructions for new macOS guidance and drop source install for now #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monthonk
suggested changes
May 26, 2022
dannycjones
force-pushed
the
fix-homebrew-instructions
branch
from
b3a75c4
to
fcf132c
Compare
monthonk
approved these changes
May 26, 2022
|
Looks good, thanks Danny. |
|
If #680 is merged before this, I think we can re-introduce the building from source options subject to testing. |
|
Closing. Change is outdated and Homebrew is no longer a supported method for install FUSE dependent connectors on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In summary, this PR reworks the installation instructions in two ways.
Firstly, it drops the installation from source instructions, with the intention to add an updated version back once working. As #696 mentions,
go installshould be used instead ofgo getnow. In terms of gettinggo installworking, I'm seeing the same issues as #527, #664.Secondly, it updates the instructions now that goofys is not available from Homebrew. This is due to a licensing change on the FUSE library used on macOS. Addresses #628.
Note, this does overlap with #618, #668, #687 but they do not address that goofys can no longer be installed via Homebrew (see Homebrew/homebrew-core#64491).
(closes #618, #668, #687)