switching fuse lib to upstream #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@kahing , this looks like a really good change and would solve people needing to use my fork of your fork for 1.17 golang. Can we get this into main? |
|
Great, hopefully a quick merge |
|
thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Goofys uses a forked version of fuse library that exposed PID to handle FlushFile operation from different processes (discussed in #273).
Now that the uptream project has implemented this jacobsa/fuse#92, we should move back there and get benefits from upstream changes.
This PR should address multiple issues we have
Tested by running
./test/run-tests.shtest.log