Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetFullName() back #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bensussman
Copy link
Contributor

This is effectively the same PR as #330 which was merged back in 2018 and allowed us at Spell to wrap goofys into a goofyscache library that solves our specific use cases that catfs does not.

We are currently live on an old version of goofys, but would like to take advantage of the recently added Azure support and in order to upgrade we need the GetFullName() method to be added back.

Thanks!

@bensussman
Copy link
Contributor Author

@kahing i'm not able to add you as a "Reviewer" or "Assignee". LMK how you'd like to proceed

@bensussman
Copy link
Contributor Author

It looks like it was removed here: e636495

although i'm not sure what the reasoning was?

@gaul
Copy link
Contributor

gaul commented Sep 17, 2020

@bensussman goofyscache sounds interesting -- can you publish this somewhere?

@bensussman
Copy link
Contributor Author

bensussman commented Sep 17, 2020

@gaul I think that can be arranged! It currently is a submodule in spell's proprietary "API" but as part of this project I have been meaning to make it its own go module, and pull it into its own git repo. I'll work on it in the coming months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants