Skip to content

Conversation

@azdanov
Copy link
Contributor

@azdanov azdanov commented Dec 22, 2024

Another attempt at sortable table, this time I've used https://tanstack.com/table/latest

I've updated only 1 table as an example to show how it can be used in the markdown document.
I also didn't verify if LLM properly converted Markdown table into JSON 🙈

@thibaultmol
Copy link
Contributor

lgtm!

@azdanov
Copy link
Contributor Author

azdanov commented Dec 24, 2024

I've added some more changes. Like custom formatting for numbers, so 1M and 128K can be properly sorted and displayed in human readable form. Also, added custom formatting for any specified token words, like "Mistral", "Meta", etc.

@azdanov
Copy link
Contributor Author

azdanov commented Dec 24, 2024

I didn't highlight anything in the last table, the llm cost, since I didn't understand the logic behind it.

@z64
Copy link
Member

z64 commented Dec 25, 2024

What was the issue with #634 ?

@azdanov
Copy link
Contributor Author

azdanov commented Dec 25, 2024

It wasn't working correctly. On page switch all the event listeners were reset so sorting stopped working.

Also, I think tanstack is production tested and more suitable than my custom implementation.

@azdanov
Copy link
Contributor Author

azdanov commented Dec 30, 2024

@z64 Would it be better to refactor this and avoid adding the new dependency on @tanstack/table?

@azdanov azdanov closed this Mar 11, 2025
@azdanov
Copy link
Contributor Author

azdanov commented Apr 18, 2025

@thibaultmol I could resurrect this PR. Just not sure why there was no feedback last time

@david-ros
Copy link
Collaborator

Hi @azdanov, sorry we couldn't review your pull request before you closed it due to the holidays. We got a similar pull request today. Maybe you can review it as I see you had figured out how to custom format numbers:
#736

@azdanov
Copy link
Contributor Author

azdanov commented Apr 18, 2025

@david-ros Sure! Also, feel free to copy anything from this PR if it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants