Merge pull request #158 from kafkajs/backwards-compatibility-hack-155

Don't include the schemaType field in API requests when type is Avro
kafkajs · Nov 3, 2021 · 823ecec · 823ecec
2 parents 72009d5 + 84c4db4
commit 823ecec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -21,7 +21,7 @@ jobs:
   - job: lint
     displayName: Lint
     pool:
-      vmImage: 'Ubuntu 16.04'
+      vmImage: 'ubuntu-latest'
     steps:
       - task: NodeTool@0
         inputs:
@@ -34,7 +34,7 @@ jobs:
   - job: build
     displayName: Build
     pool:
-      vmImage: 'Ubuntu 16.04'
+      vmImage: 'ubuntu-latest'
     steps:
       - task: NodeTool@0
         inputs:
@@ -48,7 +48,7 @@ jobs:
     displayName: Tests
     dependsOn: lint
     pool:
-      vmImage: 'Ubuntu 16.04'
+      vmImage: 'ubuntu-latest'
     steps:
       - task: NodeTool@0
         inputs:
@@ -68,7 +68,7 @@ jobs:
       - build
       - unit_tests
     pool:
-      vmImage: 'Ubuntu 16.04'
+      vmImage: 'ubuntu-latest'
     steps:
       - task: NodeTool@0
         inputs:
@@ -95,7 +95,7 @@ jobs:
       - lint
       - unit_tests
     pool:
-      vmImage: 'Ubuntu 16.04'
+      vmImage: 'ubuntu-latest'
     steps:
       - task: NodeTool@0
         inputs:

diff --git a/src/SchemaRegistry.ts b/src/SchemaRegistry.ts
@@ -136,7 +136,7 @@ export default class SchemaRegistry {
     const response = await this.api.Subject.register({
       subject: subject.name,
       body: {
-        schemaType: confluentSchema.type,
+        schemaType: confluentSchema.type === SchemaType.AVRO ? undefined : confluentSchema.type,
         schema: confluentSchema.schema,
       },
     })
@@ -234,7 +234,7 @@ export default class SchemaRegistry {
       const response = await this.api.Subject.registered({
         subject,
         body: {
-          schemaType: confluentSchema.type,
+          schemaType: confluentSchema.type === SchemaType.AVRO ? undefined : confluentSchema.type,
           schema: confluentSchema.schema,
         },
       })