Add support for OTP 27 #585
Conversation
Approaches OTP 27 -based development
I noticed rebar.lock was outdated against rebar.config
format_status/1 was introduced in OTP 25 format_status/2 is now having brod compilation fail, because of warnings_as_errors (in OTP 27) This commit presents one possibility to solve the issue: adopt the new format_status, which means that effectively brod becomes >= OTP 25 Another possibility is to remove warnings_as_errors and keep current behaviour until the function is removed from OTP I opted to remove format_status/2 from brod_supervisor/3 as it's doing mostly nothing relevant except "flagging" state.module as "Callback"
| @@ -36,7 +36,7 @@ | |||
| , handle_info/2 | |||
| , init/1 | |||
| , terminate/2 | |||
| , format_status/2 | |||
There was a problem hiding this comment.
please keep format_status/2 for older version OTP
There was a problem hiding this comment.
To do this we need to remove warnings_as_errors from the compilation options, as Erlang/OTP complains then the process stops. I'll push it, reversing the change, so you can check what happens.
There was a problem hiding this comment.
I can add an OTP_RELEASE exception, if that's what you mean.
|
Please add OTP 27 to the ci matrix. |
CI presents two distinct scenarios:
I'm gonna update the matrix, but I don't know how you prefer to deal with the env variables being fixed |
|
sorry, it seems the erlef/setup-beam@v1 has rebar3 built on otp 26. |
It's typically build on top of |
|
Thanks much. Do you have an ETA on the next release that includes this change? |
|
included in 3.19.1 |
👋
I'm not sure what the support policy/maintenance range for
brodis, but one could already start moving toward OTP 27 for systems that are adopting it.I tested these changes in my fork and CI was Ok using Erlang/OTP 27 and
rebar33.23: https://github.com/kivra-pauoli/brod/actions/runs/9564503494/job/26365813507I'll add comments on top of the changes to ease review. I tried to do commit-by-commit so it's easier to do so too, in any case.